Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

[Peter Maydell]

On 3 March 2016 at 03:23, Programmingkid <address@hidden> wrote:
> The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode
> layout.
>
> Signed-off-by: John Arbuckle <address@hidden>

> +#define LARGEST_KEYCODE 0x7E

You don't need this #define, you can just leave the array
definition as "const int mac_to_qkeycode_map[] = { ..."
and let the compiler determine the size automatically.

> +
> +// Mac to QKeyCode conversion
> +const int macToQKeyCodeMap[LARGEST_KEYCODE + 1] = {

Our coding style says variable names are all lower
case with underscores.

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM