[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] trace: include CPU index in trace_memory
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] trace: include CPU index in trace_memory_region_*() |
|
Date: |
Fri, 4 Mar 2016 15:12:57 +0000 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Mar 02, 2016 at 12:12:54PM -0800, Hollis Blanchard wrote:
> Knowing which CPU performed an action is essential for understanding SMP guest
> behavior.
>
> However, cpu_physical_memory_rw() may be executed by a machine init function,
> before any VCPUs are running, when there is no CPU running ('current_cpu' is
> NULL). In this case, store -1 in the trace record as the CPU index. Trace
> analysis tools may need to be aware of this special case.
>
> Signed-off-by: Hollis Blanchard <address@hidden>
> ---
> v2: use get_cpu_index() helper function
> ---
> memory.c | 32 ++++++++++++++++++++------------
> trace-events | 8 ++++----
> 2 files changed, 24 insertions(+), 16 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
signature.asc
Description: PGP signature