qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support


From: Samuel Thibault
Subject: Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support
Date: Mon, 7 Mar 2016 12:36:35 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Jason Wang, on Mon 07 Mar 2016 14:57:11 +0800, wrote:
> Part of the codes looks duplicated with ipv4 version. Any chances to
> merge them like tcp?

The duplication is actually quite small: accessing the ip length
is different, filling the address is different, etc.  So there are
differences all along the code.  Is it really worth the factorization?
It seems to me that it would actually *reduce* lisibility.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]