Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

[Thomas Huth]

On 07.03.2016 12:55, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
>> - the series does not build on w32:
>> In file included from ./slirp/slirp.h:126:0,
>>                  from stubs/slirp.c:3:
>> ./slirp/ip6.h:9:24: fatal error: netinet/in.h: No such file or directory
> 
> Is it the only issue?  Does it build if you add #ifndef _WIN32 around
> that include?

Is that "#include <netinet/in.h>" required in ip6.h at all? It also seems
to compile if I omit that include completely here...

Anyway, I just tried with my mingw32 cross-compiler, and once this is fixed,
compilation succeeds, but there are some warnings:

net/slirp.c: In function 'net_slirp_init':
net/slirp.c:249:5: warning: implicit declaration of function 'inet_pton' 
[-Wimplicit-function-declaration]
     if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
     ^
slirp/ip6_icmp.c: In function 'icmp6_send_error':
slirp/ip6_icmp.c:84:5: warning: implicit declaration of function 'inet_ntop' 
[-Wimplicit-function-declaration]
     inet_ntop(AF_INET6, &rip->ip_dst, addrstr, INET6_ADDRSTRLEN);
     ^
qemu/slirp/ndp_table.c: In function 'ndp_table_add':
qemu/slirp/ndp_table.c:16:5: warning: implicit declaration of function 
'inet_ntop' [-Wimplicit-function-declaration]
     inet_ntop(AF_INET6, &(ip_addr), addrstr, INET6_ADDRSTRLEN);

The warnings go away when I use this piece of code in the beginning of the 
affected files:

#ifdef _WIN32
#define _WIN32_WINNT _WIN32_WINNT_WIN6 
#include <ws2tcpip.h>
#endif

 Thomas