Re: [Qemu-devel] [PATCH v3 1/4] adb-keys.h: initial commit

[Programmingkid]

On Mar 7, 2016, at 4:10 PM, Eric Blake wrote:

> On 03/06/2016 01:35 PM, Programmingkid wrote:
>> 
>> On Mar 5, 2016, at 7:02 PM, Eric Blake wrote:
>> 
>>> On 03/04/2016 10:15 PM, Programmingkid wrote:
>>>> 
>>> 
>>>> + *
>>>> + * Permission is hereby granted, free of charge, to any person obtaining 
>>>> a copy
>>>> + * of this software and associated documentation files (the "Software"), 
>>>> to deal
>>>> + * in the Software without restriction, including without limitation the 
>>>> rights
>>>> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or 
>>>> sell
>>>> + * copies of the Software, and to permit persons to whom the Software is
>>>> + * furnished to do so, subject to the following conditions:
>>> 
>>> Any reason you chose the weaker BSD license instead of the
>>> project-default of GPLv2+?
>> 
>> Could you provide a file name or a link that has the exact text you wish to 
>> see in the file?
> 
> BSD is just fine, if you have a strong reason for preferring it (it is a
> weaker license than GPLv2+, which means GPL code can import BSD code,
> but BSD code can't import GPL code.  Personally, I try to avoid the BSD
> license on my code, because I don't like the fact that it allows
> companies to make a proprietary fork of my code, while the GPL
> guarantees that anyone using my code will keep it free.  But other
> people don't like the GPL and intentionally favor BSD for things they
> write for maximum uptake of their code.)
> 
> If you don't have a strong license preference, then there are plenty of
> GPLv2+ files you can copy from:
> 
> $ git grep -l 'GPL, version 2 or' | wc -l
> 482

Rather than place the whole license agreement in the file, could I just say 
this:

This code is licensed under the GNU GPL v2.


>>> Can you provide a URL to the source document that you used for coming up
>>> with this list, so that we can better double-check your work?  (Do it as
>>> a comment in this file, if you have one)
>> 
>> Does this look good:
>> 
>> /*
>> *  adb-keys.h
>> *
>> *  Provides an enum of all the Macintosh keycodes.
>> *  Note: keys like Power, volume related, and eject are handled at a lower
>> *        level and are not available to QEMU. That doesn't mean we can't
>> *        substitute one key for another. The function keys like F1 make a 
>> good
>> *        substitute for these keys. This can be done in the GTK, SDL, or 
>> Cocoa
>> *        code.
>> *  Additional information: 
>> http://stackoverflow.com/questions/3202629/where-can
>> *                          -i-find-a-list-of-mac-virtual-key-codes
> 
> The URL is line-broken; but still works (since stackoverflow only cares
> about the 3202629/ prefix). But yes, that sort of information source is
> useful as a code comment.

I didn't know I could shorten the url like that. I will definitely change the 
text to this:

*
*  Additional information: http://stackoverflow.com/questions/3202629
*

Thanks for this tip.