[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP
|
From: |
Jason Wang |
|
Subject: |
Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration |
|
Date: |
Tue, 8 Mar 2016 09:39:20 +0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 03/07/2016 07:24 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:53:54 +0800, wrote:
>>> + switch (ip6->ip_nh) {
>>> +#if 0
>>> + case IPPROTO_TCP:
>>> + tcp_input(m, hlen, (struct socket *)NULL);
>>> + break;
>>> + case IPPROTO_UDP:
>>> + udp_input(m, hlen);
>>> + break;
>>> +#endif
>> This looks odd, why need this?
> To pave the way for the patches after that. We can drop that from this
> patch and move to the other ones if you will, I just believe it makes
> reading this one easier since it explains how tcp and udp will be
> plugged here.
>
> Samuel
This lead warnings in checkpatch, maybe it's better to use comment instead?