qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv9 06/10] slirp: Reindent after refactoring


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCHv9 06/10] slirp: Reindent after refactoring
Date: Tue, 8 Mar 2016 09:43:05 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1


On 03/07/2016 07:38 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 15:02:53 +0800, wrote:
>> On 02/23/2016 03:28 AM, Samuel Thibault wrote:
>>> From: Guillaume Subiron <address@hidden>
>>>
>>> No code change.
>>>
>>> Signed-off-by: Guillaume Subiron <address@hidden>
>>> Signed-off-by: Samuel Thibault <address@hidden>
>>> Reviewed-by: Thomas Huth <address@hidden>
>>> ---
>>>  slirp/tcp_input.c  | 92 
>>> +++++++++++++++++++++++++++---------------------------
>>>  slirp/tcp_output.c | 29 +++++++++--------
>>>  slirp/tcp_subr.c   | 50 ++++++++++++++---------------
>> How about other files in slirp/ ?
> What do you mean?  This patch is just meant to reindent the code after
> 'if's and 'case's have been added without reindentation to make it more
> readable.
>
> Do you mean reindenting the whole slirp?  That's quite another work...
>
> Samuel
>

I'm asking since I'm not sure partial reindenting is a the best choice
for us. The patch itself is ok.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]