[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/8] Fix several unbounded stack usage
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH 0/8] Fix several unbounded stack usage |
Date: |
Tue, 8 Mar 2016 15:00:38 +0800 |
Suggested by Paolo.
Ths patchset fixes several of the warnings generated by
"-Wstack-usage=100000". There are about 20-30 unbound stack cases
during my build, and this patch is only fixing several of them,
those which are obvious and easy. For the rest, most of them need
some knowledge on specific area (e.g., USB, net, block) to have a
better assessment on the limitiation values, and are not covered in
this patchset.
One thing to mention about patch 4: I still cannot figure out why
the function xhci_dma_write_u32s() cannot be inlined in short
time... However, the current fix can at least keep the code behavior
not changed while making it stack bounded. Please let me know if
anyone knows.
Thanks.
Peter
CC: Markus Armbruster <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: "Michael S. Tsirkin" <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Richard Henderson <address@hidden>
CC: Eduardo Habkost <address@hidden>
CC: Gerd Hoffmann <address@hidden>
CC: Juan Quintela <address@hidden>
CC: Amit Shah <address@hidden>
CC: Luiz Capitulino <address@hidden>
CC: address@hidden
Peter Xu (8):
qdict: fix unbounded stack for qdict_array_entries
block: fix unbounded stack for dump_qdict
usb: fix unbounded stack for ohci_td_pkt
usb: fix unbounded stack for xhci_dma_write_u32s
usb: fix unbounded stack for inotify_watchfn
usb: fix unbounded stack for usb_mtp_add_str
migration: fix unbounded stack for source_return_path_thread
hw/i386: fix unbounded stack for load_multiboot
block/qapi.c | 5 ++++-
hw/i386/multiboot.c | 10 +++++++++-
hw/usb/dev-mtp.c | 13 +++++++++----
hw/usb/hcd-ohci.c | 7 ++++---
hw/usb/hcd-xhci.c | 12 ++++++++----
migration/migration.c | 7 ++++---
qobject/qdict.c | 15 +++++++++------
7 files changed, 47 insertions(+), 22 deletions(-)
--
2.4.3
- [Qemu-devel] [PATCH 0/8] Fix several unbounded stack usage,
Peter Xu <=
- [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Peter Xu, 2016/03/08
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Peter Xu, 2016/03/08
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Eric Blake, 2016/03/08
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Peter Xu, 2016/03/08
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Kevin Wolf, 2016/03/09