Re: [Qemu-devel] [PATCH 5/8] usb: fix unbounded stack for inotify_watchfn

[Paolo Bonzini]

On 08/03/2016 08:20, Peter Maydell wrote:
>> > +#define __BUF_LEN (sizeof(struct inotify_event) + NAME_MAX + 1)
>> >      /* From the man page: atleast one event can be read */
>> > -    int len = sizeof(struct inotify_event) + NAME_MAX + 1;
>> >      int pos;
>> > -    char buf[len];
>> > +    char buf[__BUF_LEN];
> The commit message subject says this is fixing an unbounded
> stack usage, but (a) this array wasn't unbounded in size
> (b) the change doesn't change the size we allocate.
> What are you trying to do here?

I suspect it's just fixing a false positive in the compiler.

Paolo