[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap |
|
Date: |
Tue, 8 Mar 2016 14:18:33 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 08.03.2016 um 09:24 hat Fam Zheng geschrieben:
> All three functions are not in hot path (all run once for the BDS lifecycle),
> so it's okay to convert to g_malloc0.
Yeah, it's okay, but still kind of useless to memset the whole buffer
before you overwrite it anyway. There's also a useless ret = 0 somewhere.
I'd prefer not to do that in the next series.
Anyway, thanks, applied to the block branch.
Kevin