Re: [Qemu-devel] [PATCH v4 05/10] qapi: Utilize implicit struct visits

[Eric Blake]

On 03/08/2016 09:11 AM, Eric Blake wrote:

>>>
>>> -    ret += gen_visit_members(arg_type.members, skiperr=dealloc)
>>
>> Unless I'm mistaken, this is the only use of skiperr.  Follow up with a
>> patch to drop the parameter and simplify?
> 
> Oh, nice.  I noticed some cleanups in patch 6/10, but missed this one as
> a reasonable improvement.
> 
> In fact, gen_visit_members() is now only used in qapi-visits.py, so
> maybe I can move it back there (it used to live there before commit
> 82ca8e469 moved it for sharing with the two files simplified here).

In fact, this also nukes the only use of c_null().  I'll have a couple
of cleanup patches in v5.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature