Re: [Qemu-devel] [PULL 0/8] VFIO updates 2016-03-09

[Peter Maydell]

On 10 March 2016 at 12:03, Peter Maydell <address@hidden> wrote:
> On 10 March 2016 at 02:53, Alex Williamson <address@hidden> wrote:
>> The following changes since commit 4ba364b47275fe428723442987b57b260b215dba:
>>
>>   Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into 
>> staging (2016-03-09 05:14:55 +0000)
>>
>> are available in the git repository at:
>>
>>
>>   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20160309.0
>>
>> for you to fetch changes up to 799f7b98c501e5aec0a539119613787cd5705136:
>>
>>   MAINTAINERS: Add entry for the include/hw/vfio/ folder (2016-03-09 
>> 11:19:14 -0700)
>>
>> ----------------------------------------------------------------
>> VFIO updates 2016-03-09
>>
>>  - Allow devices to be specified via sysfs path (Alex Williamson)
>>  - vfio region helpers and generalization for future device specific regions
>>    (Alex Williamson)
>>  - Automatic ROM device ID and checksum fixup (Alex Williamson)
>>  - Split VGA setup to allow enabling VGA from quirks (Alex Williamson)
>>  - Remove fixed string limit for ROM MemoryRegion name (Neo Jia)
>>  - MAINTAINERS update (Thomas Huth)
>
> Fails to build on 32-bit I'm afraid:
> ./trace/generated-tracers.h: In function 'trace_vfio_msix_fixup':
> ./trace/generated-tracers.h:16113:23: error: format '%lx' expects
> argument of type 'long unsigned int', but argument 8 has type 'off_t'
> [-Werror=format=]
>                        , name, bar, offset, size);
>                        ^
> ./trace/generated-tracers.h:16113:23: error: format '%lx' expects
> argument of type 'long unsigned int', but argument 9 has type 'size_t'
> [-Werror=format=]
>   CC    block.o

Similarly, OSX warns about the off_t argument:
../trace/generated-tracers.h:16113:36: warning: format specifies type
'unsigned long' but the argument has type 'off_t'
      (aka 'long long') [-Wformat]
                      , name, bar, offset, size);
                                   ^~~~~~
1 warning generated.

thanks
-- PMM