Re: [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Hi
>
> On Wed, Mar 9, 2016 at 9:14 PM, Markus Armbruster <address@hidden> wrote:
>>> @@ -77,7 +77,7 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int 
>>> argc, char *argv[])
>>>                         "F"  /* foreground */
>>>                         "p:" /* pid_file */
>>>                         "S:" /* unix_socket_path */
>>> -                       "m:" /* shm_path */
>>> +                       "m:" /* dirname */
>>
>> The existing comments all name the member of args set by the option.
>> There is no member dirname.
>
> I read from help: "-m <dirname>: where to create shared memory"

Differently logical.  In your interpretation, the comments are of very
little value.  In mine, even less.  That makes yours "superior".

>>>                         "M:" /* shm_path */
>>>                         "l:" /* shm_size */
>>>                         "n:" /* n_vectors */
[...]