qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 01/21] osdep: fix socket_error() to work with


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH v1 01/21] osdep: fix socket_error() to work with Mingw64
Date: Thu, 10 Mar 2016 16:13:17 +0000
User-agent: Mutt/1.5.24 (2015-08-30)

On Thu, Mar 10, 2016 at 05:12:36PM +0100, Paolo Bonzini wrote:
> 
> 
> On 09/03/2016 18:28, Daniel P. Berrange wrote:
> > +    case WSAEWOULDBLOCK:
> > +        return EWOULDBLOCK;
> 
> On mingw EAGAIN != EWOULDBLOCK.  Can you instead return EAGAIN here, so
> that we can get rid of the "... || errno == EWOULDBLOCK" everywhere?

Oh yes, that's a good idea.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]