Re: [Qemu-devel] [PATCH v4 3/4] adb-keys.h: initial commit

[Peter Maydell]

On 11 March 2016 at 02:29, Programmingkid <address@hidden> wrote:
> This commit implements the adb-keys.h file. It holds information on adb 
> keycode
> values.
>
> Signed-off-by: John Arbuckle <address@hidden>

> +
> +    ADB_KEY_GRAVE_ACCENT = 50,
> +    ADB_KEY_MINUS = 27,
> +    ADB_KEY_EQUAL = 24,
> +    ADB_KEY_DELETE = 51,
> +    ADB_KEY_CAPS_LOCK = 57,
> +    ADB_KEY_TAB = 48,
> +    ADB_KEY_RETURN = 36,
> +    ADB_KEY_LEFT_BRACKET = 33,
> +    ADB_KEY_RIGHT_BRACKET = 30,
> +    ADB_KEY_BACKSLASH = 42,
> +    ADB_KEY_SEMICOLON = 41,
> +    ADB_KEY_APOSTROPHE = 39,
> +    ADB_KEY_COMMA = 43,
> +    ADB_KEY_PERIOD = 47,
> +    ADB_KEY_FORWARD_SLASH = 44,
> +    ADB_KEY_LEFT_SHIFT = 56,
> +    ADB_KEY_RIGHT_SHIFT = 60,
> +    ADB_KEY_SPACEBAR = 49,
> +    ADB_KEY_LEFT_CONTROL = 59,
> +    ADB_KEY_RIGHT_CONTROL = 62,
> +    ADB_KEY_LEFT_OPTION = 58,
> +    ADB_KEY_RIGHT_OPTION = 61,
> +    ADB_KEY_LEFT_COMMAND = 55,
> +    ADB_KEY_RIGHT_COMMAND = 54,

> +    ADB_KEY_UP = 126,
> +    ADB_KEY_DOWN = 125,
> +    ADB_KEY_LEFT = 123,
> +    ADB_KEY_RIGHT = 124,

Looking at
http://www.archive.org/stream/apple-guide-macintosh-family-hardware/Apple_Guide_to_the_Macintosh_Family_Hardware_2e#page/n347/mode/2up

page 308/309, the codes you have here appear to be the
"keyboard driver codes", ie the ones you get after MacOS
has remapped them, not the "transition codes", ie the ones
the hardware actually generates.

In particular the transition codes for the right shift/option/control
are 0x7B/7C/7D, which are what you have here for KEY_LEFT/RIGHT/DOWN,
which is probably why you're then getting weird behaviour.

I suggest rechecking all these ADB keycodes against the
diagram on page 308.

thanks
-- PMM