qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list
Date: Tue, 15 Mar 2016 09:45:22 +0100

> Depends on how you code it up.  We have a list, we look each file
> there and sort accordingly.  Fine.
> New devices will not be on this list, I guess you can just ignore them
> and guests will not see them. OK but I think it is better to make old
> machine types see them.

Not a new fw_cfg file.

It's existing smbios file which gets new records added by a new device.
So when initializing it early (old order) it doesn't (yet) contain the
new records.  When initializing it late it has them, but also has a
different place in the fw_cfg directory.

So old machine types initialize smbios early (for compatibility).

New machine types initialize smbios late (so guests see the new
records).

While mucking with the file ordering anyway:  Good opportunity to make
new machine types also sort the fw_cfg directory entries, so they get a
fixed order independent from the order they are created, and we will not
face this problem again.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]