[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h |
Date: |
Tue, 15 Mar 2016 17:04:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 15/03/2016 16:03, Markus Armbruster wrote:
> diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h
> index 2dabe49..904501a 100644
> --- a/include/ui/qemu-spice.h
> +++ b/include/ui/qemu-spice.h
> @@ -23,6 +23,7 @@
>
> #include <spice.h>
>
> +#include "qapi/error.h"
> #include "qemu/option.h"
> #include "qemu/config-file.h"
>
This must be moved outside the #ifdef CONFIG_SPICE, because
ui/qemu-spice.h uses error_set call outside that #ifdef.
Paolo
- Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers, (continued)
- Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers, Paolo Bonzini, 2016/03/15
- Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers, Markus Armbruster, 2016/03/15
- Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers, Paolo Bonzini, 2016/03/15
- Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers, Peter Maydell, 2016/03/15
- Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers, Paolo Bonzini, 2016/03/15
- Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers, Peter Maydell, 2016/03/15
- Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers, Markus Armbruster, 2016/03/15
[Qemu-devel] [PATCH 15/15] Drop superfluous qemu-common.h inclusions, Markus Armbruster, 2016/03/15
[Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h, Markus Armbruster, 2016/03/15
- Re: [Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h,
Paolo Bonzini <=
Re: [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h, Paolo Bonzini, 2016/03/15