Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

[Michael S. Tsirkin]

On Thu, Mar 17, 2016 at 03:50:08PM +0100, Paolo Bonzini wrote:
> 
> 
> On 17/03/2016 15:17, Michael S. Tsirkin wrote:
> > On Thu, Mar 17, 2016 at 02:55:52PM +0100, Paolo Bonzini wrote:
> >>
> >>
> >> On 17/03/2016 14:49, Michael S. Tsirkin wrote:
> >>>> On 17/03/2016 14:13, Michael S. Tsirkin wrote:
> >>>>>
> >>>>> QEMU command line:
> >>>>>         A. -fw-cfg RFQDN/PATH prepends usr/. So users will not get 
> >>>>> conflicts
> >>>>>            with QEMU hardware
> >>>>
> >>>> Alternative: no need to prepend usr/, I think.
> >>>
> >>> I personally dislike telling user "do X". I don't see a reason not to be
> >>> friendly and do X. The rare case where users do not want X can be
> >>> easily enabled.
> >>
> >> I wouldn't include usr/ at all in the paths.  The RFQDN recommendation
> >> is enough to avoid clashes with etc/ and opt/.
> > 
> > Yes but then we need a blacklist.
> 
> Can't the blacklist be as simple as "org.qemu/*", plus some handling of
> legacy "etc/*"?
> 
> We'd need special handling of "etc/*" anyway because SeaBIOS is using it
> (Gerd's usecase) and you certainly don't want to use
> org.qemu/unsupported/etc/XYZ hacks for that.
> 
> Paolo

I would prefer a white-list, but I have an idea: look for "."
in the name. If not there, it's not an RFQDN.

-- 
MST