[Qemu-devel] [PATCH v6 00/16] easier unboxed visits/qapi implicit types

[Eric Blake]

Addresses Markus' comments on v5, similar to his qapi-not-next
branch, with some commit message improvements.  Adds a cleanup
to visit_needed() in patch 5, renames patch 6, splits patch 7
into two, and adds a new patch 16.

Built directly on master qemu.git.

Also available as a tag at this location:
git fetch git://repo.or.cz/qemu/ericb.git qapi-implicit-v6

and will soon be part of my branch at:
http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi

v5: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02289.html

001/16:[----] [--] 'qapi: Assert in places where variants are not handled'
002/16:[----] [--] 'qapi: Fix command with named empty argument type'
003/16:[----] [--] 'qapi: Make c_type() more OO-like'
004/16:[----] [--] 'qapi: Adjust names of implicit types'
005/16:[0020] [FC] 'qapi: Emit implicit structs in generated C'
006/16:[down] 'qapi-event: Drop qmp_output_get_qobject() null check'
007/16:[down] 'qapi-event: Utilize implicit struct visits'
008/16:[down] 'qapi-commands: Utilize implicit struct visits'
009/16:[0010] [FC] 'qapi-commands: Inline single-use helpers of gen_marshal()'
010/16:[----] [--] 'qapi: Inline gen_visit_members() into lone caller'
011/16:[----] [--] 'qapi: Drop unused c_null()'
012/16:[----] [--] 'qapi: Don't special-case simple union wrappers'
013/16:[----] [--] 'qapi: Make BlockdevOptions doc example closer to reality'
014/16:[----] [-C] 'qapi: Allow anonymous base for flat union'
015/16:[----] [--] 'qapi: Use anonymous bases in QMP flat unions'
016/16:[down] 'qapi: Consolidate object visitors'

Eric Blake (16):
  qapi: Assert in places where variants are not handled
  qapi: Fix command with named empty argument type
  qapi: Make c_type() more OO-like
  qapi: Adjust names of implicit types
  qapi: Emit implicit structs in generated C
  qapi-event: Drop qmp_output_get_qobject() null check
  qapi-event: Utilize implicit struct visits
  qapi-commands: Utilize implicit struct visits
  qapi-commands: Inline single-use helpers of gen_marshal()
  qapi: Inline gen_visit_members() into lone caller
  qapi: Drop unused c_null()
  qapi: Don't special-case simple union wrappers
  qapi: Make BlockdevOptions doc example closer to reality
  qapi: Allow anonymous base for flat union
  qapi: Use anonymous bases in QMP flat unions
  qapi: Consolidate object visitors

 scripts/qapi.py                            | 181 +++++++++++------------------
 scripts/qapi-commands.py                   | 117 +++++++------------
 scripts/qapi-event.py                      |  53 ++++++---
 scripts/qapi-introspect.py                 |  10 +-
 scripts/qapi-types.py                      |  39 ++++---
 scripts/qapi-visit.py                      |  70 +++++------
 backends/baum.c                            |   2 +-
 backends/msmouse.c                         |   2 +-
 block/nbd.c                                |   6 +-
 block/qcow2.c                              |   6 +-
 block/vmdk.c                               |   8 +-
 blockdev.c                                 |  24 ++--
 hmp.c                                      |   8 +-
 hw/char/escc.c                             |   2 +-
 hw/input/hid.c                             |   8 +-
 hw/input/ps2.c                             |   6 +-
 hw/input/virtio-input-hid.c                |   8 +-
 hw/mem/pc-dimm.c                           |   2 +-
 net/dump.c                                 |   2 +-
 net/hub.c                                  |   2 +-
 net/l2tpv3.c                               |   2 +-
 net/net.c                                  |   4 +-
 net/netmap.c                               |   2 +-
 net/slirp.c                                |   2 +-
 net/socket.c                               |   2 +-
 net/tap-win32.c                            |   2 +-
 net/tap.c                                  |   4 +-
 net/vde.c                                  |   2 +-
 net/vhost-user.c                           |   2 +-
 numa.c                                     |   4 +-
 qemu-char.c                                |  82 ++++++-------
 qemu-nbd.c                                 |   6 +-
 replay/replay-input.c                      |  44 +++----
 spice-qemu-char.c                          |  14 ++-
 tests/test-io-channel-socket.c             |  40 +++----
 tests/test-qmp-commands.c                  |   7 +-
 tests/test-qmp-input-visitor.c             |  25 ++--
 tests/test-qmp-output-visitor.c            |  24 ++--
 tpm.c                                      |   2 +-
 ui/console.c                               |   4 +-
 ui/input-keymap.c                          |  10 +-
 ui/input-legacy.c                          |   8 +-
 ui/input.c                                 |  34 +++---
 ui/vnc-auth-sasl.c                         |   3 +-
 ui/vnc.c                                   |  29 ++---
 util/qemu-sockets.c                        |  35 +++---
 docs/qapi-code-gen.txt                     |  98 ++++++++--------
 qapi-schema.json                           |  20 +---
 qapi/block-core.json                       |  98 +++++++---------
 qapi/introspect.json                       |  12 +-
 tests/qapi-schema/comments.out             |   2 +-
 tests/qapi-schema/empty.out                |   2 +-
 tests/qapi-schema/event-case.out           |   2 +-
 tests/qapi-schema/flat-union-bad-base.err  |   2 +-
 tests/qapi-schema/flat-union-bad-base.json |   5 +-
 tests/qapi-schema/ident-with-escape.out    |   8 +-
 tests/qapi-schema/include-relpath.out      |   2 +-
 tests/qapi-schema/include-repetition.out   |   2 +-
 tests/qapi-schema/include-simple.out       |   2 +-
 tests/qapi-schema/indented-expr.out        |   2 +-
 tests/qapi-schema/qapi-schema-test.json    |   8 +-
 tests/qapi-schema/qapi-schema-test.out     | 166 +++++++++++++-------------
 62 files changed, 661 insertions(+), 719 deletions(-)

-- 
2.5.0