Re: [Qemu-devel] commit 084a85e breaks build

[Markus Armbruster]

You forgot to cc: Dan.  Fixed :)

I see similar diagnostics from F22's gcc.  Linking fails:

../crypto/cipher.o: In function `qcrypto_cipher_new':
/home/armbru/work/qemu/crypto/cipher-nettle.c:229: undefined reference to 
`cast5_set_key'
/home/armbru/work/qemu/crypto/cipher-nettle.c:230: undefined reference to 
`cast5_set_key'
/home/armbru/work/qemu/crypto/cipher-nettle.c:232: undefined reference to 
`cast5_set_key'


"Gabriel L. Somlo" <address@hidden> writes:

> Hi Daniel,
>
> I get the error below when I try to build QEMU, and bisect claims it
> started with commit 084a85e (crypto: add support for the cast5-128
> cipher algorithm).
>
> Sorry if this is already a known issue. Let me know if there's
> anything you'd like me to test.
>
> My command line is:
> ~/KVM-OSX/SCRATCH/qemu/configure --prefix=/home/somlo/KVM-OSX/SCRATCH 
> --audio-drv-list=pa 
> --target-list=x86_64-softmmu,i386-softmmu,aarch64-softmmu,arm-softmmu; make 
> install
>
> Thanks,
> --Gabriel
>
> ...
>   CC    crypto/cipher.o
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c: In function
> ‘qcrypto_cipher_new’:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:229:13: error:
> implicit declaration of function ‘cast5_set_key’
> [-Werror=implicit-function-declaration]
>              cast5_set_key(ctx->ctx, nkey, key);
>              ^
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:229:13: error:
> nested extern declaration of ‘cast5_set_key’ [-Werror=nested-externs]
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c: In function
> ‘qcrypto_cipher_encrypt’:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:344:21: error:
> passing argument 3 of ‘xts_encrypt’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>                      ctx->alg_encrypt, ctx->alg_encrypt,
>                      ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
> /home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:76:6: note:
> expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
> {aka void (*)(const void *, long unsigned int,  unsigned char *, const
> unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
> int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
> unsigned char *, const unsigned char *)}’
>  void xts_encrypt(const void *datactx,
>       ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:344:39: error:
> passing argument 4 of ‘xts_encrypt’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>                      ctx->alg_encrypt, ctx->alg_encrypt,
>                                        ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
> /home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:76:6: note:
> expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
> {aka void (*)(const void *, long unsigned int,  unsigned char *, const
> unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
> int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
> unsigned char *, const unsigned char *)}’
>  void xts_encrypt(const void *datactx,
>       ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c: In function
> ‘qcrypto_cipher_decrypt’:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:389:21: error:
> passing argument 3 of ‘xts_decrypt’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>                      ctx->alg_encrypt, ctx->alg_decrypt,
>                      ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
> /home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:54:6: note:
> expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
> {aka void (*)(const void *, long unsigned int,  unsigned char *, const
> unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
> int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
> unsigned char *, const unsigned char *)}’
>  void xts_decrypt(const void *datactx,
>       ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:0:
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:389:39: error:
> passing argument 4 of ‘xts_decrypt’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>                      ctx->alg_encrypt, ctx->alg_decrypt,
>                                        ^
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher-nettle.c:22:0,
>                  from
> /home/somlo/KVM-OSX/SCRATCH/qemu/crypto/cipher.c:153:
> /home/somlo/KVM-OSX/SCRATCH/qemu/include/crypto/xts.h:54:6: note:
> expected ‘void (*)(const void *, size_t,  uint8_t *, const uint8_t *)
> {aka void (*)(const void *, long unsigned int,  unsigned char *, const
> unsigned char *)}’ but argument is of type ‘void (*)(void *, unsigned
> int,  uint8_t *, const uint8_t *) {aka void (*)(void *, unsigned int,
> unsigned char *, const unsigned char *)}’
>  void xts_decrypt(const void *datactx,
>       ^
> cc1: all warnings being treated as errors
> /home/somlo/KVM-OSX/SCRATCH/qemu/rules.mak:57: recipe for target
> 'crypto/cipher.o' failed
> make: *** [crypto/cipher.o] Error 1