[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] QMP: add query-hotpluggable-cpus
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] QMP: add query-hotpluggable-cpus |
Date: |
Mon, 21 Mar 2016 11:53:23 +0100 |
On Fri, 18 Mar 2016 16:26:28 -0300
Eduardo Habkost <address@hidden> wrote:
> On Tue, Mar 15, 2016 at 02:24:07PM +0100, Igor Mammedov wrote:
> [...]
> > diff --git a/stubs/qmp_query_hotpluggable_cpus.c
> > b/stubs/qmp_query_hotpluggable_cpus.c
> > new file mode 100644
> > index 0000000..21a75a3
> > --- /dev/null
> > +++ b/stubs/qmp_query_hotpluggable_cpus.c
> > @@ -0,0 +1,9 @@
> > +#include "qemu/osdep.h"
> > +#include "qapi/qmp/qerror.h"
> > +#include "qmp-commands.h"
> > +
> > +HotpluggableCPUList *qmp_query_hotpluggable_cpus(Error **errp)
> > +{
> > + error_setg(errp, QERR_FEATURE_DISABLED, "query-hotpluggable-cpus");
> > + return NULL;
> > +}
>
> Sorry if this was discussed in previous threads that I haven't
> read, but: isn't this supposed to be a MachineClass method? I
> remember David saying once that we have the habit of assuming
> that a single QEMU binary can run only one family of machines
> that are very similar (like x86), but that's not always true.
Stub approach works for current qemu with one target per binary
but it won't for multi-target binary.
I've been trying to not clutter MachineClass with hooks
that not must have right now but I don't have a strong opinion
on this so if MachineClass method is preferred way,
I can rewrite it this patch to use it on respin.
[Qemu-devel] [RFC v3 2/2] spapr: implement query-hotpluggable-cpus QMP command, Igor Mammedov, 2016/03/15
Re: [Qemu-devel] [PATCH v3 0/2] spapr: QMP: add query-hotpluggable-cpus, Christian Borntraeger, 2016/03/16
Re: [Qemu-devel] [PATCH v3 0/2] spapr: QMP: add query-hotpluggable-cpus, Markus Armbruster, 2016/03/22