[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon()
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon() |
|
Date: |
Mon, 21 Mar 2016 15:53:07 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/18/2016 04:31 AM, Kevin Wolf wrote:
> The call in hmp_drive_del() is dead code because blk_remove_bs() is
> called a few lines above. The only other remaining user is
> bdrv_delete(), which only abuses bdrv_make_anon() to remove it from the
> named nodes list. This path inlines the list entry removal into
> bdrv_delete() and removes bdrv_make_anon().
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 15 +++------------
> blockdev.c | 3 ---
> include/block/block.h | 1 -
> 3 files changed, 3 insertions(+), 16 deletions(-)
Nice diffstat, as well.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature