[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 00/40] ivshmem: Fixes, cleanups, device model
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL v2 00/40] ivshmem: Fixes, cleanups, device model split |
Date: |
Tue, 22 Mar 2016 16:40:31 +0000 |
On 21 March 2016 at 20:43, Markus Armbruster <address@hidden> wrote:
> Major issues addressed by this series:
>
> * The specification document is incomplete and vague. Rewritten.
>
> * When a peer goes away, and its ID gets reused for another one,
> interrupts don't work.
>
> * When configured for interrupts, we receive shared memory from the
> server some time after realize(). This creates a (usually
> short-lived) "no shared memory, yet" state. If the guest wins the
> race, it is exposed to this state (known issue, if you count burying
> in docs/specs/ as "known"). If migration wins the race, it fails or
> corrupts memory.
>
> * Interrupts are unreliable in a (usually small) time window after the
> destination peer connects. I believe fixing this will require
> changing the client/server protocol, so just document it for now.
>
> * The device isn't capable to tell guest software whether it is
> configured for interrupts. Fix that in a new, backwards-compatible
> revision of the guest ABI, and bump the PCI revision. Deprecate the
> old revision.
>
> * The device properties are a confusing mess and badly checked.
> Clean that up.
>
> * Migration with interrupts relies on server behavior not guaranteed
> by the specification. Tighten the specification.
>
> v2:
> * PATCH 05: Include ivshmem-test only in configurations that include
> the device
> * PATCH 36: Fix ivshmem-plain not to assert its nonexistent INTx
Hi -- this appears to be missing the git URL to pull from?
thanks
-- PMM
- [Qemu-devel] [PULL v2 37/40] ivshmem: Clean up after the previous commit, (continued)
- [Qemu-devel] [PULL v2 37/40] ivshmem: Clean up after the previous commit, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 26/40] ivshmem: Propagate errors through ivshmem_recv_setup(), Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 40/40] contrib/ivshmem-server: Print "not for production" warning, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 36/40] ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 21/40] ivshmem: Assert interrupts are set up once, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 33/40] ivshmem: Inline check_shm_size() into its only caller, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 28/40] ivshmem: Drop the hackish test for UNIX domain chardev, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 30/40] ivshmem: Tighten check of property "size", Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 09/40] ivshmem-test: Improve test cases /ivshmem/server-*, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 23/40] ivshmem: Disentangle ivshmem_read(), Markus Armbruster, 2016/03/21
- Re: [Qemu-devel] [PULL v2 00/40] ivshmem: Fixes, cleanups, device model split,
Peter Maydell <=