Re: [Qemu-devel] [PATCH v5 04/15] register: Add support for decoding information

[Alex Bennée]

Alistair Francis <address@hidden> writes:

> Allow defining of optional address decoding information in register
> definitions. This is useful for clients that want to associate
> registers with specific addresses.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
> V3:
>  - Remove unused flags option
>
>  include/hw/register.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/include/hw/register.h b/include/hw/register.h
> index 726a914..bc2c96a 100644
> --- a/include/hw/register.h
> +++ b/include/hw/register.h
> @@ -39,6 +39,11 @@ typedef struct RegisterInfoArray RegisterInfoArray;
>   * allowing this function to modify the value before return to the client.
>   */
>
> +#define REG_DECODE_READ (1 << 0)
> +#define REG_DECODE_WRITE (1 << 1)
> +#define REG_DECODE_EXECUTE (1 << 2)
> +#define REG_DECODE_RW (REG_DECODE_READ | REG_DECODE_WRITE)
> +
>  struct RegisterAccessInfo {
>      const char *name;
>      uint64_t ro;

Without any other context I'm unsure of how these defines are going to
be used. Are these just bits at the bottom of an address?

Nothing in this patch series uses them so I suggest you drop this patch
for now.

--
Alex Bennée