[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation. |
Date: |
Wed, 23 Mar 2016 14:48:13 +0000 |
On 19 March 2016 at 20:59, Jean-Christophe Dubois <address@hidden> wrote:
> The sabrelite supports one SPI FLASH memory on SPI1
>
> Signed-off-by: Jean-Christophe Dubois <address@hidden>
> + {
> + /* Add the sst25vf016b NOR FLASH memory to first SPI */
> + Object *spi_dev;
> +
> + spi_dev = object_resolve_path_component(OBJECT(&s->soc), "spi1");
Can you add a comment to remind us there's a todo here:
/* Ideally we would expose the chip select and spi bus on the SoC
* object using alias properties; then we would not need to directly
* access the underlying spi device object.
*/
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v4 1/6] ARM: Factor out ARM on/off PSCI control functions, (continued)
[Qemu-devel] [PATCH v4 2/6] i.MX: Add i.MX6 System Reset Controller device., Jean-Christophe Dubois, 2016/03/19
[Qemu-devel] [PATCH v4 3/6] FIFO: Add a FIFO32 implementation, Jean-Christophe Dubois, 2016/03/19
[Qemu-devel] [PATCH v4 4/6] i.MX: Add the Freescale SPI Controller, Jean-Christophe Dubois, 2016/03/19
[Qemu-devel] [PATCH v4 5/6] i.MX: Add i.MX6 SOC implementation., Jean-Christophe Dubois, 2016/03/19
[Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation., Jean-Christophe Dubois, 2016/03/19
- Re: [Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation.,
Peter Maydell <=