qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state
Date: Thu, 24 Mar 2016 16:12:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0


On 24/03/2016 16:11, Pavel Butsykin wrote:
>>
> You want something like this:
> dma_cb()
> {
> ...
>     if (ret < 0) {
>         if (ide_handle_rw_error(s, -ret, ide_dma_cmd_to_retry(s))) {
>             return;
>         }
>     }
> ...
> }
> 
> static void ide_bmdma_pre_save(void *opaque)
> {
> ...
>     if (!(bm->status & BM_STATUS_DMAING) && bm->dma_cb) {
>         bm->bus->error_status = ide_dma_cmd_to_retry(bmdma_active_if(bm));
>     }
> ...
> }

Yes, that would do.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]