[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] blizzard: Remove support for DEPTH != 32
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] blizzard: Remove support for DEPTH != 32 |
|
Date: |
Fri, 25 Mar 2016 11:09:37 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, 03/24 23:48, Pooja Dhannawat wrote:
> Removing support for DEPTH != 32 from blizzard template header
> and file that includes it, as macro DEPTH == 32 only used.
>
> Signed-off-by: Pooja Dhannawat <address@hidden>
Hi Pooja, a meta-comment: in the future, when post a subsequent revision,
please include what is changed since previous revision, in the cover letter if
there are multiple patches, or under a "---" line in the commit message if
there is no cover letter. (Remember that the Signed-off-by line must still stay
above the "---" line).
The reason to use "---" line is for maintainers to avoid "git am" applying the
revision changelog into git history (apparently it is meaningless out of patch
review context).
In this case, it would be like:
----8<---
Removing support for DEPTH != 32 from blizzard template header
and file that includes it, as macro DEPTH == 32 only used.
Signed-off-by: Pooja Dhannawat <address@hidden>
---
v4: Changed foo to bar, and baz to qux. [$name_of_suggester]
---->8---