Re: [Qemu-devel] [PATCH 08/20] block: Always set writeback mode in blk_new_open()

[Max Reitz]

On 18.03.2016 19:21, Kevin Wolf wrote:
> All callers of blk_new_open() either don't rely on the WCE bit set after
> blk_new_open() because they explicitly set it anyway, or they pass
> BDRV_O_CACHE_WB unconditionally.
> 
> This patch changes blk_new_open() so that it always enables writeback
> mode and asserts that BDRV_O_CACHE_WB is clear. For those callers that
> used to pass BDRV_O_CACHE_WB unconditionally, the flag is removed now.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/block-backend.c | 4 ++++
>  block/parallels.c     | 3 +--
>  block/qcow.c          | 3 +--
>  block/qcow2.c         | 9 +++------
>  block/qed.c           | 3 +--
>  block/sheepdog.c      | 5 ++---
>  block/vdi.c           | 3 +--
>  block/vhdx.c          | 3 +--
>  block/vmdk.c          | 8 +++-----
>  block/vpc.c           | 3 +--
>  blockdev.c            | 1 +
>  11 files changed, 19 insertions(+), 26 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature