qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] pci: fix compilation warnings


From: Marcel Apfelbaum
Subject: [Qemu-devel] [PATCH] pci: fix compilation warnings
Date: Mon, 28 Mar 2016 10:23:17 +0300

Fix 'error: shift exponent -1 is negative' warning
by adding a corresponding assert.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
---
 hw/pci/pci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index e67664d..a1d41aa 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -163,11 +163,15 @@ int pci_bar(PCIDevice *d, int reg)
 
 static inline int pci_irq_state(PCIDevice *d, int irq_num)
 {
+    assert(irq_num >= 0);
+
        return (d->irq_state >> irq_num) & 0x1;
 }
 
 static inline void pci_set_irq_state(PCIDevice *d, int irq_num, int level)
 {
+    assert(irq_num >= 0);
+
        d->irq_state &= ~(0x1 << irq_num);
        d->irq_state |= level << irq_num;
 }
-- 
2.4.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]