[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() i
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f() |
Date: |
Tue, 29 Mar 2016 15:48:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 |
On 29.03.2016 15:30, Kevin Wolf wrote:
> We must forbid changing the WCE flag in bdrv_reopen() in the same patch,
> as otherwise the behaviour would change so that the flag takes
> precedence over the explicitly specified option.
>
> The correct value of the WCE flag depends on the BlockBackend user (e.g.
> guest device) and isn't a decision that the QMP client makes, so this
> change is what we want.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 18 ++++++------------
> qemu-io-cmds.c | 14 +++++++++++++-
> tests/qemu-iotests/142 | 2 +-
> tests/qemu-iotests/142.out | 2 +-
> 4 files changed, 21 insertions(+), 15 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
For some weird reason I thought that blk_enable_write_cache() always
returned true here. Which is not true, of course.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 14/20] nbd: Support BDRV_REQ_FUA, (continued)
- [Qemu-devel] [PATCH v2 11/20] block/qapi: Use blk_enable_write_cache(), Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 16/20] block: Use bdrv_parse_cache_mode() in drive_init(), Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 10/20] block: Move enable_write_cache to BB level, Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 09/20] block: Handle flush error in bdrv_pwrite_sync(), Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 08/20] block: Always set writeback mode in blk_new_open(), Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 12/20] block: Introduce bdrv_co_writev_flags(), Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 15/20] raw: Support BDRV_REQ_FUA, Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f(), Kevin Wolf, 2016/03/29
- Re: [Qemu-devel] [PATCH v2 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f(),
Max Reitz <=
- [Qemu-devel] [PATCH v2 18/20] block: Remove bdrv_parse_cache_flags(), Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 20/20] block: Remove bdrv_(set_)enable_write_cache(), Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 13/20] iscsi: Support BDRV_REQ_FUA, Kevin Wolf, 2016/03/29
- [Qemu-devel] [PATCH v2 19/20] block: Remove BDRV_O_CACHE_WB, Kevin Wolf, 2016/03/29