[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user/signal.c: Generate opcode data for r
From: |
Chen Gang |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user/signal.c: Generate opcode data for restorer in setup_rt_frame |
Date: |
Tue, 29 Mar 2016 21:53:44 +0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 3/29/16 06:57, Chen Gang wrote:
> On 3/29/16 06:17, Laurent Vivier wrote:
>>
>> The address of retcode in host and guest can differ.
>> You need something like:
>>
>> restorer = (unsigned long)(frame_addr + offsetof(struct
>> target_rt_sigframe, retcode));
>>
>> I've experienced this on sh4 (see commit 2a0fa68)
>>
>
> OK, thanks. What you said above sounds reasonable to me. :-)
>
> I shall send patch v2 for it (although tilegx is a pure 64-bit target,
> with this patch, I guess, tilegx target should still run correctly under
> 32-bit host).
>
> By the way, it looks that s390x and microblaze targets also have the
> same issue.
It looks the alpha target may also need consider about retcode, for "r26
= frame_addr" in setup_rt_frame().
Thanks.
--
Chen Gang (陈刚)
Managing Natural Environments is the Duty of Human Beings.