[Qemu-devel] [PULL 10/48] block/qapi: fix unbounded stack for dump_qdict

[Kevin Wolf]

From: Peter Xu <address@hidden>

Using heap instead of stack for better safety.

Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
 block/qapi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/block/qapi.c b/block/qapi.c
index 7be3f4a..775dcf5 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -668,7 +668,7 @@ static void dump_qdict(fprintf_function func_fprintf, void 
*f, int indentation,
     for (entry = qdict_first(dict); entry; entry = qdict_next(dict, entry)) {
         QType type = qobject_type(entry->value);
         bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST);
-        char key[strlen(entry->key) + 1];
+        char *key = g_malloc(strlen(entry->key) + 1);
         int i;
 
         /* replace dashes with spaces in key (variable) names */
@@ -682,6 +682,7 @@ static void dump_qdict(fprintf_function func_fprintf, void 
*f, int indentation,
         if (!composite) {
             func_fprintf(f, "\n");
         }
+        g_free(key);
     }
 }
 
-- 
1.8.3.1