[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] NBD proto: add "Command flags" section
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] NBD proto: add "Command flags" section |
|
Date: |
Tue, 29 Mar 2016 10:03:37 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 03/29/2016 10:01 AM, Eric Blake wrote:
> On 03/28/2016 04:43 AM, Denis V. Lunev wrote:
>> From: Pavel Borzenkov <address@hidden>
>>
>> Add separate "Command flags" section to make it clear which flags are
>> currently defined by the protocol.
>>
>> Signed-off-by: Pavel Borzenkov <address@hidden>
>> Reviewed-by: Roman Kagan <address@hidden>
>> Signed-off-by: Denis V. Lunev <address@hidden>
>> CC: Wouter Verhelst <address@hidden>
>> CC: Eric Blake <address@hidden>
>> CC: Alex Bligh <address@hidden>
>> ---
>> doc/proto.md | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/doc/proto.md b/doc/proto.md
>> index 036d6d9..662f741 100644
>> --- a/doc/proto.md
>> +++ b/doc/proto.md
>> @@ -485,6 +485,16 @@ The following request types exist:
>> Currently one such message is known: `NBD_CMD_CACHE`, with type set to
>> 5, implemented by xnbd.
>>
>> +#### Command flags
>> +
>
> I think that this new content would belong better as a subsection under
> '#### Flag Fields', alongside the mention of all other flags. I'm going
> to propose a v2 of this patch with that alternate position, for comparison.
Hmm, maybe not. I just looked again, and '#### Flag fields' is a
subsection of '### Handshake phase', while you are correct that command
flags belong to '### Transmission phase'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature