Re: [Qemu-devel] [PULL 00/48] Block layer patches

[Peter Maydell]

On 29 March 2016 at 16:08, Kevin Wolf <address@hidden> wrote:
> The following changes since commit b68a80139e37e806f004237e55311ebc42151434:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into 
> staging (2016-03-24 16:24:02 +0000)
>
> are available in the git repository at:
>
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to b63f2a6772ca774ec58b2fc6e26fdeeda44a99c1:
>
>   iotests: Test qemu-img convert -S 0 behavior (2016-03-29 16:30:13 +0200)
>
> ----------------------------------------------------------------
> Block layer patches

Hi. I'm afraid this doesn't compile:

/Users/pm215/src/qemu-for-merges/block/blkreplay.c:38:9: warning:
implicit declaration of function 'error_propagate' is invalid in C99
[-Wimplicit-function-declaration]
        error_propagate(errp, local_err);
        ^

/Users/pm215/src/qemu-for-merges/block/crypto.c:68:9: warning:
implicit declaration of function 'error_setg_errno' is invalid in C99
[-Wimplicit-function-declaration]
        error_setg_errno(errp, -ret, "Could not read encryption header");
        ^
/Users/pm215/src/qemu-for-merges/block/crypto.c:116:66: error: use of
undeclared identifier 'error_abort'
    qemu_opt_set_number(data->opts, BLOCK_OPT_SIZE, data->size, &error_abort);
                                                                 ^
/Users/pm215/src/qemu-for-merges/block/crypto.c:217:9: warning:
implicit declaration of function 'error_setg' is invalid in C99
[-Wimplicit-function-declaration]
        error_setg(&local_err, "Unsupported block format %d", format);
        ^
/Users/pm215/src/qemu-for-merges/block/crypto.c:220:5: warning:
implicit declaration of function 'error_propagate' is invalid in C99
[-Wimplicit-function-declaration]
    error_propagate(errp, local_err);
    ^
/Users/pm215/src/qemu-for-merges/block/crypto.c:296:50: error: use of
undeclared identifier 'error_abort'
    opts = qemu_opts_create(opts_spec, NULL, 0, &error_abort);
                                                 ^

Looks like you've also been hit by commit da34e65cb4025, which
means you now need to explicitly include qapi/error.h if you need it.

thanks
-- PMM