[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6 |
Date: |
Wed, 30 Mar 2016 10:38:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 |
On 29.03.2016 01:44, Samuel Thibault wrote:
> Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and
> IPv6-only network environments.
>
> Signed-off-by: Samuel Thibault <address@hidden>
>
> ---
>
> Changes since previous versions:
>
> - fix coding style
> ---
> net/slirp.c | 36 ++++++++++++++++++++++++++++++------
> qapi-schema.json | 8 ++++++++
> qemu-options.hx | 8 ++++++--
> slirp/ip6_icmp.c | 8 ++++++++
> slirp/ip6_input.c | 5 +++++
> slirp/ip_input.c | 4 ++++
> slirp/libslirp.h | 3 ++-
> slirp/slirp.c | 10 +++++++++-
> slirp/slirp.h | 2 ++
> 9 files changed, 74 insertions(+), 10 deletions(-)
>
[...]
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 09162f5..705f162 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1551,8 +1551,9 @@ DEF("smb", HAS_ARG, QEMU_OPTION_smb, "", QEMU_ARCH_ALL)
>
> DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
> #ifdef CONFIG_SLIRP
> - "-netdev
> user,id=str[,net=addr[/mask]][,host=addr][,ipv6-net=addr[/int]]\n"
> - "
> [,ipv6-host=addr][,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
> + "-netdev user,id=str[,ipv4][,net=addr[/mask]][,host=addr]\n"
> + " [,ipv6][,ipv6-net=addr[/int]][,ipv6-host=addr]\n"
> + " [,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
> " [,dns=addr][,ipv6-dns=addr][,dnssearch=domain][,tftp=dir]\n"
> " [,bootfile=f][,hostfwd=rule][,guestfwd=rule]"
Shouldn't that rather be "[,ipv4=on|off]" and "[,ipv6=on|off]" for a
boolean value?
Apart from that, the patch looks fine to me.
Thomas
- [Qemu-devel] [PATCH 0/5] ipv4-only and ipv6-only support, Samuel Thibault, 2016/03/28
- [Qemu-devel] [PATCH 5/5] slirp: Add RDNSS advertisement, Samuel Thibault, 2016/03/28
- [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6, Samuel Thibault, 2016/03/28
- Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6,
Thomas Huth <=
- Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6, Samuel Thibault, 2016/03/30
- Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6, Thomas Huth, 2016/03/30
- Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6, Samuel Thibault, 2016/03/30
- Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6, Thomas Huth, 2016/03/30
- Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6, Samuel Thibault, 2016/03/30
- Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6, Eric Blake, 2016/03/30
[Qemu-devel] [PATCH 2/5] slirp: Split get_dns_addr, Samuel Thibault, 2016/03/28
[Qemu-devel] [PATCH 3/5] slirp: Add dns6 resolution, Samuel Thibault, 2016/03/28