Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

[Peter Maydell]

On 31 March 2016 at 15:19, Samuel Thibault <address@hidden> wrote:
> Peter Maydell, on Thu 31 Mar 2016 15:11:27 +0100, wrote:
>> On 31 March 2016 at 13:51, Samuel Thibault <address@hidden> wrote:
>> > Peter Maydell, on Thu 31 Mar 2016 13:47:28 +0100, wrote:
>> >> On 31 March 2016 at 10:20, Samuel Thibault <address@hidden> wrote:
>> >> >   Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100)
>> >> >
>> >> > are available in the git repository at:
>> >> >
>> >> >   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2
>> >> >
>> >> > for you to fetch changes up to c99751f2a711e9eecf60901520c6d4197bdaf9b4:
>> >> >
>> >> >   slirp: Add RDNSS advertisement (2016-03-31 11:18:13 +0200)
>> >> >
>> >> > ----------------------------------------------------------------
>> >> > slirp updates (2)
>> >> >
>> >> > ----------------------------------------------------------------
>> >> > Samuel Thibault (5):
>> >> >       slirp: Allow disabling IPv4 or IPv6
>> >> >       slirp: Split get_dns_addr
>> >> >       slirp: Add dns6 resolution
>> >> >       slirp: Support link-local DNS addresses
>> >> >       slirp: Add RDNSS advertisement
>> >>
>> >> Hi. I'm afraid this doesn't build for Windows:
>> >
>> > Indeed, I forgot to fix the the windows version of the function, could
>> > you try with the attached change?
>>
>> I'm afraid that's not sufficient:
>
> Ah, this is using -Werror, OK, here are more fixes.

Still nope:
/home/petmay01/linaro/qemu-for-merges/slirp/socket.c: In function
‘sotranslate_out’:
/home/petmay01/linaro/qemu-for-merges/slirp/socket.c:799:17: error:
passing argument 2 of ‘get_dns6_addr’ from incompatible pointer type
[-Werror]
                 if (get_dns6_addr(&sin6->sin6_addr,
&sin6->sin6_scope_id) < 0) {
                 ^
In file included from /home/petmay01/linaro/qemu-for-merges/slirp/slirp.h:99:0,
                 from /home/petmay01/linaro/qemu-for-merges/slirp/socket.c:10:
/home/petmay01/linaro/qemu-for-merges/slirp/libslirp.h:10:5: note:
expected ‘uint32_t *’ but argument is of type ‘u_long *’
 int get_dns6_addr(struct in6_addr *pdns6_addr, uint32_t *scope_id);
     ^
cc1: all warnings being treated as errors

thanks
-- PMM