Re: [Qemu-devel] [PATCH for-2.6] target-i386: KVM loves Hyper-V!

[Paolo Bonzini]

On 01/04/2016 10:58, Daniel P. Berrange wrote:
> On Fri, Apr 01, 2016 at 10:18:02AM +0200, Paolo Bonzini wrote:
>> Microsoft loves Linux, and Red Hat loves .NET.  Since we can put whatever
>> we want in the Hyper-V vendor signature, let's show some love too!
>>
>> Cc: Andreas Färber <address@hidden>
>> Cc: Alex Williamson <address@hidden>
>> Cc: Denis V. Lunev <address@hidden>
>> Cc: Eduardo Habkost <address@hidden>
>> Cc: Roman Kagan <address@hidden>
>> Cc: KY Srinivasan <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>  target-i386/kvm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>> index 799fdfa..1968f04 100644
>> --- a/target-i386/kvm.c
>> +++ b/target-i386/kvm.c
>> @@ -592,7 +592,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>>          c = &cpuid_data.entries[cpuid_i++];
>>          c->function = HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS;
>>          if (!cpu->hyperv_vendor_id) {
>> -            memcpy(signature, "Microsoft Hv", 12);
>> +            memcpy(signature, "KVM<3HyperV!", 12);
> 
> I think it'd be nicer to use the unicode heart symbol ♡ encoded as utf-8
> eg
> 
>   memcpy(signature, "KVM\xe2\x99\xa1HyperV", 12);

I'll try to get v2 ready in the next 13 hours and 53 minutes.

Paolo