[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tci: Fix build regression
|
From: |
Stefan Weil |
|
Subject: |
Re: [Qemu-devel] [PATCH] tci: Fix build regression |
|
Date: |
Mon, 4 Apr 2016 22:40:38 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 |
Am 04.04.2016 um 20:06 schrieb Sergey Fedorov:
> On 04/04/16 20:50, Stefan Weil wrote:
>> -/* Defining NDEBUG disables assertions (which makes the code faster). */
>> -#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG)
>> -# define NDEBUG
>> +/* Enable TCI assertions only when debugging TCG (and without NDEBUG
>> defined).
>> + * Without assertions, the interpreter runs much faster. */
>> +#if defined(CONFIG_DEBUG_TCG)
>> +# define tci_assert(cond) assert(cond)
>> +#else
>> +# define tci_assert(cond) (void)0
>
> Maybe wrap the "(void)0" into parentheses?
>
> Kind regards,
> Sergey
>
>> #endif
>
Maybe. It's not needed for the current code.
Are there situations where parentheses for this would make a difference?
Stefan
signature.asc
Description: OpenPGP digital signature