[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] crypto: fix nettle config check for running pbk
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] crypto: fix nettle config check for running pbkdf test |
Date: |
Tue, 5 Apr 2016 11:40:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 04/04/2016 17:24, Daniel P. Berrange wrote:
> The pbkdf test is being built based on a check for CONFIG_NETTLE.
> As of fff2f982ab6ac0dd2b641d30303f72270a019f28, it should be
> instead checking CONFIG_NETTLE_KDF
>
> Reported-by: "Dr. David Alan Gilbert" <address@hidden>
> Reported-by: Bruce Rogers <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 45b9048..651d8b2 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -92,7 +92,7 @@ check-unit-$(CONFIG_GNUTLS) +=
> tests/test-io-channel-tls$(EXESUF)
> check-unit-y += tests/test-io-channel-command$(EXESUF)
> check-unit-y += tests/test-io-channel-buffer$(EXESUF)
> check-unit-y += tests/test-base64$(EXESUF)
> -check-unit-$(if $(CONFIG_NETTLE),y,$(CONFIG_GCRYPT_KDF)) +=
> tests/test-crypto-pbkdf$(EXESUF)
> +check-unit-$(if $(CONFIG_NETTLE_KDF),y,$(CONFIG_GCRYPT_KDF)) +=
> tests/test-crypto-pbkdf$(EXESUF)
> check-unit-y += tests/test-crypto-ivgen$(EXESUF)
> check-unit-y += tests/test-crypto-afsplit$(EXESUF)
> check-unit-y += tests/test-crypto-xts$(EXESUF)
Peter, could you please apply this directly to master for rc1?
Thanks,
Paolo