Re: [Qemu-devel] [RFC v2 4/6] hw/misc: sdm virtio device

[Baptiste Reynal]

On Thu, Mar 31, 2016 at 11:12 AM, Stefan Hajnoczi <address@hidden> wrote:
> On Fri, Mar 18, 2016 at 10:13:03AM +0100, Baptiste Reynal wrote:
>> This is the virtio implementation for an SDM device.
>>
>> Parameters are:
>> comm=[sdm_communication_id] specifies the communication channel
>> master=[true/false] - configure the SDM device as master or slave
>> num_slaves=[slave_number] - if master is true, specifies the number
>> of slaves
>> len-signals=[signals_number] - specifies the number of signals
>> signals[x]=[signal_id] - add a signal to the device, with the ID x
>>
>> Signed-off-by: Christian Pinto <address@hidden>
>> Signed-off-by: Baptiste Reynal <address@hidden>
>> ---
>>  hw/virtio/Makefile.objs          |   1 +
>>  hw/virtio/virtio-sdm.c           | 262 
>> +++++++++++++++++++++++++++++++++++++++
>>  include/hw/virtio/virtio-sdm.h   |  60 +++++++++
>>  linux-headers/linux/virtio_sdm.h |  52 ++++++++
>>  4 files changed, 375 insertions(+)
>>  create mode 100644 hw/virtio/virtio-sdm.c
>>  create mode 100644 include/hw/virtio/virtio-sdm.h
>>  create mode 100644 linux-headers/linux/virtio_sdm.h
>
> Have you posted a draft specification for this device to the VIRTIO
> Technical Committee?
> https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio
>
> Normally the spec should be accepted into VIRTIO before patches can be
> merged.
Thanks for the comment, I wasn't aware of such process.
I'll wait for some comments on the SDM in general, then I'll send a
draft spec to virtio.
Maybe this patchs should be dropped and reintroduced in a future patch series ?
>
> Stefan