[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checki
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking |
Date: |
Tue, 5 Apr 2016 16:28:45 +0100 |
On 4 April 2016 at 14:39, <address@hidden> wrote:
> From: Vijay <address@hidden>
>
> Use Neon instructions to perform zero checking of
> buffer. This is helps in reducing downtime during
> live migration.
One other comment I forgot:
> +#define NEON_VECTYPE uint64x2_t
This is a 128-bit type...
> +static size_t buffer_find_nonzero_offset_neon(const void *buf, size_t len)
> +{
> + size_t i;
> + NEON_VECTYPE d0, d1, d2, d3, d4, d5, d6;
> + NEON_VECTYPE d7, d8, d9, d10, d11, d12, d13, d14;
...so it's a bit confusing to use d0, d1, etc, which implies
a 64-bit value.
thanks
-- PMM