Re: [Qemu-devel] powerpc: Clear user CPU feature bits if TM is disabled at runtime

[Michael Ellerman]

On 5 April 2016 7:56:23 pm AEST, Benjamin Herrenschmidt <address@hidden> wrote:
>On Tue, 2016-04-05 at 19:35 +1000, Michael Ellerman wrote:
>> Shouldn't we be clearing the user feature there too?
>> 
>> The ibm_pa_features array and the logic in scan_features() knows to
>> flip the
>> cpu_user_features bits, it was just never updated to handle
>> cpu_user_features2.
>> 
>> So it seems to me that's where the bug is.
>
>I was about to make the same comment but then realized we are trying to
>clear *2* bits. And since that logic will also, I think, set the bits
>when the corresponding pa-feature is present, it means we will also set
>those 2 bits if we put both in the mask...

That's what we want in this case. The 2nd bit describes Linux's behaviour of 
aborting active transactions in syscalls, so kernels that have that bit defined 
should be setting/clearing it in lock step with the main TM bit. 

cheers
-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.