qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 2/5] change pvscsi_init_msi() type to void


From: Dmitry Fleytman
Subject: Re: [Qemu-devel] [PATCH v4 2/5] change pvscsi_init_msi() type to void
Date: Wed, 6 Apr 2016 10:19:11 +0300

Acked-by: Dmitry Fleytman <address@hidden>

Why not...

On 5 Apr 2016, at 14:26 PM, Cao jin <address@hidden> wrote:

Nobody use its return value, so change the type to void

Signed-off-by: Cao jin <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Dmitry Fleytman <address@hidden>
---
hw/scsi/vmw_pvscsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
index 9abc086..4ce3581 100644
--- a/hw/scsi/vmw_pvscsi.c
+++ b/hw/scsi/vmw_pvscsi.c
@@ -1039,7 +1039,7 @@ pvscsi_io_read(void *opaque, hwaddr addr, unsigned size)
}


-static bool
+static void
pvscsi_init_msi(PVSCSIState *s)
{
    int res;
@@ -1053,8 +1053,6 @@ pvscsi_init_msi(PVSCSIState *s)
    } else {
        s->msi_used = true;
    }
-
-    return s->msi_used;
}

static void
--
2.1.0





reply via email to

[Prev in Thread] Current Thread [Next in Thread]