[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 7/7] qemu-iotests: iotests.py: get
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__ |
Date: |
Wed, 6 Apr 2016 18:18:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 05.04.2016 11:21, Sascha Silbe wrote:
> The __all__ list contained a typo for as long as the iotests module
> existed. That typo prevented "from iotests import *" (which is the
> only case where iotests.__all__ is used at all) from ever working.
Hahaha :D
Nice one.
> The names used by iotests are highly prone to name collisions, so
> importing them all unconditionally is a bad idea anyway. Since __all__
> is not adding any value, let's just get rid of it.
>
> Fixes: f345cfd0 ("qemu-iotests: add iotests Python module")
> Signed-off-by: Sascha Silbe <address@hidden>
> Reviewed-by: Bo Tu <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 4 ----
> 1 file changed, 4 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] next round of qemu-iotests fixes, Sascha Silbe, 2016/04/05
- [Qemu-devel] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__, Sascha Silbe, 2016/04/05
- Re: [Qemu-devel] [Qemu-block] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__,
Max Reitz <=
- [Qemu-devel] [PATCH 5/7] qemu-iotests: 068: don't require KVM, Sascha Silbe, 2016/04/05
- [Qemu-devel] [PATCH 2/7] qemu-iotests: fix 051 on non-PC architectures, Sascha Silbe, 2016/04/05
- [Qemu-devel] [PATCH 3/7] qemu-iotests: iotests.VM: remove qtest socket on error, Sascha Silbe, 2016/04/05
- [Qemu-devel] [PATCH 1/7] qemu-iotests: check: don't place files with predictable names in /tmp, Sascha Silbe, 2016/04/05