[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the gue
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest |
Date: |
Thu, 7 Apr 2016 02:17:10 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Hello,
Steven Luo, on Wed 06 Apr 2016 17:00:50 -0700, wrote:
> That said, sorecvoob() also calls soread(), so I'd guess we need to
> deal with the possibility that soread() frees the socket in that case
> as well?
Indeed, then sorecvoob() needs to return that information, so
slirp_pollfds_poll can avoid doing anything else with this socket.
> I could take care of this when I resend this patch series, if you
> prefer.
If you like, please do :)
> I think this should be "might have been removed"? tcp_sockclosed()
> doesn't seem to call tcp_close() in every case, so we can get -1 from
> soread() without the socket being freed.
Right.
Samuel
- [Qemu-devel] [PATCH 1/3] slirp: don't crash when tcp_sockclosed() is called with a NULL tp, (continued)
- [Qemu-devel] [PATCH 1/3] slirp: don't crash when tcp_sockclosed() is called with a NULL tp, steven, 2016/04/05
- [Qemu-devel] [PATCH 2/3] slirp: Propagate host TCP RST to the guest., steven, 2016/04/05
- [Qemu-devel] [PATCH 3/3] slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets, steven, 2016/04/05
- Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest, Thomas Huth, 2016/04/06
- Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest, Edgar E. Iglesias, 2016/04/06
- Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest, Samuel Thibault, 2016/04/06