[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386: kvmvapic: initialise imm32 variable
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] i386: kvmvapic: initialise imm32 variable |
|
Date: |
Thu, 7 Apr 2016 10:47:48 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 07/04/2016 09:20, P J P wrote:
> From: Prasad J Pandit <address@hidden>
>
> When processing Task Priorty Register(TPR) access, it could leak
> automatic stack variable 'imm32' in patch_instruction().
> Initialise the variable to avoid it.
>
> Reported by: Donghai Zdh <address@hidden>
>
> Signed-off-by: Prasad J Pandit <address@hidden>
> ---
> hw/i386/kvmvapic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
> index c69f374..ff1e31a 100644
> --- a/hw/i386/kvmvapic.c
> +++ b/hw/i386/kvmvapic.c
> @@ -394,7 +394,7 @@ static void patch_instruction(VAPICROMState *s, X86CPU
> *cpu, target_ulong ip)
> CPUX86State *env = &cpu->env;
> VAPICHandlers *handlers;
> uint8_t opcode[2];
> - uint32_t imm32;
> + uint32_t imm32 = 0;
> target_ulong current_pc = 0;
> target_ulong current_cs_base = 0;
> int current_flags = 0;
>
Queued for 2.6, thanks.
Paolo