[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH COLO-Frame v16 34/35] COLO: manage the status of buf
From: |
zhanghailiang |
Subject: |
[Qemu-devel] [PATCH COLO-Frame v16 34/35] COLO: manage the status of buffer filters for PVM |
Date: |
Fri, 8 Apr 2016 14:26:36 +0800 |
Enable all buffer filters that added by COLO while
go into COLO process, and disable them while exit COLO.
Signed-off-by: zhanghailiang <address@hidden>
Cc: Jason Wang <address@hidden>
Cc: Yang Hongyang <address@hidden>
---
v16:
- Stop buffer filter while doing checkpoint and resume it after
checkpoint.
v15:
- Re-implement colo_set_filter_status() based on COLOBufferFilters list.
- Fix the title of this patch
---
migration/colo.c | 33 ++++++++++++++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/migration/colo.c b/migration/colo.c
index 7a60bc1..6a9caa2 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -114,10 +114,22 @@ static void secondary_vm_do_failover(void)
}
}
+static void colo_set_filter_status(const char *status, Error **errp)
+{
+ struct COLOListNode *e, *next;
+ NetFilterState *nf;
+
+ QLIST_FOREACH_SAFE(e, &COLOBufferFilters, node, next) {
+ nf = e->opaque;
+ object_property_set_str(OBJECT(nf), status, "status", errp);
+ }
+}
+
static void primary_vm_do_failover(void)
{
MigrationState *s = migrate_get_current();
int old_state;
+ Error *local_err = NULL;
migrate_set_state(&s->state, MIGRATION_STATUS_COLO,
MIGRATION_STATUS_COMPLETED);
@@ -141,6 +153,12 @@ static void primary_vm_do_failover(void)
old_state);
return;
}
+
+ colo_set_filter_status("off", &local_err);
+ if (local_err) {
+ error_report_err(local_err);
+ }
+
/* Notify COLO thread that failover work is finished */
qemu_sem_post(&s->colo_sem);
}
@@ -299,7 +317,11 @@ static int colo_do_checkpoint_transaction(MigrationState
*s,
if (failover_request_is_active()) {
goto out;
}
-
+ /* Stop buffer filter and flush the buffered packets */
+ colo_set_filter_status("off", &local_err);
+ if (local_err) {
+ goto out;
+ }
colo_send_message(s->to_dst_file, COLO_MESSAGE_VMSTATE_SEND, &local_err);
if (local_err) {
goto out;
@@ -363,6 +385,10 @@ static int colo_do_checkpoint_transaction(MigrationState
*s,
qemu_thread_exit(0);
}
+ colo_set_filter_status("on", &local_err);
+ if (local_err) {
+ goto out;
+ }
ret = 0;
/* Resume primary guest */
qemu_mutex_lock_iothread();
@@ -432,6 +458,11 @@ static void colo_process_checkpoint(MigrationState *s)
failover_init_state();
+ colo_set_filter_status("on", &local_err);
+ if (local_err) {
+ goto out;
+ }
+
s->rp_state.from_dst_file = qemu_file_get_return_path(s->to_dst_file);
if (!s->rp_state.from_dst_file) {
error_report("Open QEMUFile from_dst_file failed");
--
1.8.3.1
- [Qemu-devel] [PATCH COLO-Frame v16 25/35] COLO: Update the global runstate after going into colo state, (continued)
- [Qemu-devel] [PATCH COLO-Frame v16 25/35] COLO: Update the global runstate after going into colo state, zhanghailiang, 2016/04/08
- [Qemu-devel] [PATCH COLO-Frame v16 30/35] COLO: Split qemu_savevm_state_begin out of checkpoint process, zhanghailiang, 2016/04/08
- [Qemu-devel] [PATCH COLO-Frame v16 32/35] net: Add notifier/callback for netdev init, zhanghailiang, 2016/04/08
- [Qemu-devel] [PATCH COLO-Frame v16 15/35] COLO: Add checkpoint-delay parameter for migrate-set-parameters, zhanghailiang, 2016/04/08
- [Qemu-devel] [PATCH COLO-Frame v16 08/35] COLO: Add a new RunState RUN_STATE_COLO, zhanghailiang, 2016/04/08
- [Qemu-devel] [PATCH COLO-Frame v16 31/35] filter-buffer: Accept zero interval, zhanghailiang, 2016/04/08
- [Qemu-devel] [PATCH COLO-Frame v16 29/35] COLO: Separate the process of saving/loading ram and device state, zhanghailiang, 2016/04/08
- [Qemu-devel] [PATCH COLO-Frame v16 34/35] COLO: manage the status of buffer filters for PVM,
zhanghailiang <=
- [Qemu-devel] [PATCH COLO-Frame v16 35/35] COLO: Add block replication into colo process, zhanghailiang, 2016/04/08
- [Qemu-devel] [PATCH COLO-Frame v16 33/35] COLO/filter: add each netdev a buffer filter, zhanghailiang, 2016/04/08
- [Qemu-devel] [PATCH COLO-Frame v16 22/35] COLO failover: Shutdown related socket fd when do failover, zhanghailiang, 2016/04/08
- Re: [Qemu-devel] [PATCH COLO-Frame v16 for-2.7 00/35] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT), Zhang Chen, 2016/04/08
- Re: [Qemu-devel] [PATCH COLO-Frame v16 for-2.7 00/35] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT), Dr. David Alan Gilbert, 2016/04/22