[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-input: add parenthesis to const_le32
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio-input: add parenthesis to const_le32 |
|
Date: |
Mon, 11 Apr 2016 10:14:23 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 04/11/2016 09:19 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> include/hw/virtio/virtio-input.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
An explanation would have been helpful.
> #if defined(HOST_WORDS_BIGENDIAN)
> # define const_le32(_x) \
> - (((_x & 0x000000ffU) << 24) | \
The problem you are fixing is that _x needs parenthesis.
> + ((((_x) & 0x000000ffU) << 24) | \
and you indeed added it, but I had to hunt because there was no
explanation in the commit message.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature