Re: [Qemu-devel] [PATCH 1/2] xenfb: use the correct condition to avoid excessive looping

[Anthony PERARD]

On Tue, Apr 12, 2016 at 10:57:16AM +0100, Wei Liu wrote:
> In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <=
> out_cons"), ">=" was used. In fact, a full ring is a legit state.
> Correct the test to use ">".
> 
> Reported-by: "Hao, Xudong" <address@hidden>
> Signed-off-by: Wei Liu <address@hidden>
> Tested-by: "Hao, Xudong" <address@hidden>

Acked-by: Anthony PERARD <address@hidden>

> ---
> Cc: Stefano Stabellini <address@hidden>
> Cc: Anthony Perard <address@hidden>
> 
> Backport candidate to our own tree.
> ---
>  hw/display/xenfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index 40b096a..9866dfd 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -775,7 +775,7 @@ static void xenfb_handle_events(struct XenFB *xenfb)
>  
>      prod = page->out_prod;
>      out_cons = page->out_cons;
> -    if (prod - out_cons >= XENFB_OUT_RING_LEN) {
> +    if (prod - out_cons > XENFB_OUT_RING_LEN) {
>          return;
>      }
>      xen_rmb();               /* ensure we see ring contents up to prod */
> -- 
> 2.1.4
> 

-- 
Anthony PERARD