[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 1/9] virtio-input: add parenthesis to const_le{16,
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL v2 1/9] virtio-input: add parenthesis to const_le{16, 32} |
Date: |
Wed, 13 Apr 2016 17:44:55 +0200 |
"_x" must be "(_x)" otherwise things fail if you pass in expressions.
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
---
include/hw/virtio/virtio-input.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/hw/virtio/virtio-input.h b/include/hw/virtio/virtio-input.h
index af1c207..169adee 100644
--- a/include/hw/virtio/virtio-input.h
+++ b/include/hw/virtio/virtio-input.h
@@ -15,13 +15,13 @@ typedef struct virtio_input_event virtio_input_event;
#if defined(HOST_WORDS_BIGENDIAN)
# define const_le32(_x) \
- (((_x & 0x000000ffU) << 24) | \
- ((_x & 0x0000ff00U) << 8) | \
- ((_x & 0x00ff0000U) >> 8) | \
- ((_x & 0xff000000U) >> 24))
+ ((((_x) & 0x000000ffU) << 24) | \
+ (((_x) & 0x0000ff00U) << 8) | \
+ (((_x) & 0x00ff0000U) >> 8) | \
+ (((_x) & 0xff000000U) >> 24))
# define const_le16(_x) \
- (((_x & 0x00ff) << 8) | \
- ((_x & 0xff00) >> 8))
+ ((((_x) & 0x00ff) << 8) | \
+ (((_x) & 0xff00) >> 8))
#else
# define const_le32(_x) (_x)
# define const_le16(_x) (_x)
--
1.8.3.1
- [Qemu-devel] [PULL v2 0/9] virtio-input; live migration support, various bugfixes, Gerd Hoffmann, 2016/04/13
- [Qemu-devel] [PULL v2 7/9] virtio-input: fix emulated tablet axis ranges, Gerd Hoffmann, 2016/04/13
- [Qemu-devel] [PULL v2 9/9] virtio-input: support absolute axis config in pass-through, Gerd Hoffmann, 2016/04/13
- [Qemu-devel] [PULL v2 6/9] virtio-input: add live migration support, Gerd Hoffmann, 2016/04/13
- [Qemu-devel] [PULL v2 2/9] move const_le{16, 23} to qemu/bswap.h, add comment, Gerd Hoffmann, 2016/04/13
- [Qemu-devel] [PULL v2 1/9] virtio-input: add parenthesis to const_le{16, 32},
Gerd Hoffmann <=
- [Qemu-devel] [PULL v2 3/9] virtio-input: add missing key mappings, Gerd Hoffmann, 2016/04/13
- [Qemu-devel] [PULL v2 8/9] input-linux: refine mouse detection, Gerd Hoffmann, 2016/04/13
- [Qemu-devel] [PULL v2 5/9] virtio-input: implement pass-through evdev writes, Gerd Hoffmann, 2016/04/13
- [Qemu-devel] [PULL v2 4/9] virtio-input: retrieve EV_LED host config bits, Gerd Hoffmann, 2016/04/13
- Re: [Qemu-devel] [PULL v2 0/9] virtio-input; live migration support, various bugfixes, Peter Maydell, 2016/04/14